Private files preview and google drawings support #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekfdd
commented
Nov 4, 2020
abhishekfdd
commented
- Fixes Preview for private files
- Adds google drawings embed support
SID177
suggested changes
Nov 4, 2020
| $basedir = ''; | ||
| $baseurl = ''; | ||
|
|
||
| $file_id = $this->get_file_id_from_url( $url ); |
There was a problem hiding this comment.
Indentation. = should align with = below.
| $baseurl = ''; | ||
|
|
||
| $file_id = $this->get_file_id_from_url( $url ); | ||
| $cached_data = $this->get_cached_data_from_file_id( $file_id ); |
There was a problem hiding this comment.
We're already getting cached file URL in get_thumbnail_url function, then why do we need this code again? $thumbnail_url itself is a cached URL here if the file is cached.
| </a> | ||
| <img src="<?php echo esc_url( $thumbnail_url ); ?>" alt="<?php esc_attr_e( 'Shared Document Preview', 'rt-google-embeds' ); ?>" style="border: 1px solid #eee; margin: 15px auto; display: block;" /> | ||
| </div> | ||
| if ( file_exists( $cached_file ) ) : ?> |
There was a problem hiding this comment.
This is not supposed to be done here. Do this before calling render_embed function and pass only 1 URL here. That URL will be used here directly.
|
@abhishekfdd We will only pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.