Cache preview images of docs locally & Fix showing doc preview issues #6
Conversation
itowhid06
changed the title
|
@SID177 Whenever you are available, please review this PR |
| // Check if retrieved http code is 200. | ||
| $status_code = wp_remote_retrieve_response_code( $response ); | ||
| if ( 200 === $status_code ) { | ||
| // Save the thumbnail. | ||
| $this->save_thumbnail( $file_id, $contents ); |
There was a problem hiding this comment.
You need to cache image which is being fetched on line 322 of this file too. And test once if it's working fine even after token is expired
There was a problem hiding this comment.
Did you try implementing this? Current save_thumbnail call will only work for public files, not for private files. In order for this to work with private files, you'll need to do what I've suggested above.
There was a problem hiding this comment.
Also get_thumbnail_url function should return cached URL if network request fails. If all the network requests fails, then at the end you can check whether the file of this ID is already cached, if it is then send that URL.
| $cached_url = esc_url_raw( $upload_dir['baseurl'] . "/cache/wp-google-drive/{$file_id}.png" ); | ||
|
|
||
| var_dump( $cached_file ); | ||
| var_dump( $cached_url ); |
There was a problem hiding this comment.
Why there are var_dump here?
|
|
||
| preg_match( '/[-\w]{25,}/', $url, $matches ); | ||
| if ( ! empty( $matches[0] ) ) { | ||
| $file_id = $matches[0]; |
There was a problem hiding this comment.
I think if the matches are empty then it shouldn't go ahead.
| $matches = array(); | ||
| $file_id = ''; | ||
| $basedir = ''; | ||
| $baseurl = ''; |
| $basedir = ''; | ||
| $baseurl = ''; | ||
|
|
||
| preg_match( '/[-\w]{25,}/', $url, $matches ); |
There was a problem hiding this comment.
Use get_file_id_from_url existing function instead.
| // Check if retrieved http code is 200. | ||
| $status_code = wp_remote_retrieve_response_code( $response ); | ||
| if ( 200 === $status_code ) { | ||
| // Save the thumbnail. | ||
| $this->save_thumbnail( $file_id, $contents ); |
There was a problem hiding this comment.
Did you try implementing this? Current save_thumbnail call will only work for public files, not for private files. In order for this to work with private files, you'll need to do what I've suggested above.
| // Check if retrieved http code is 200. | ||
| $status_code = wp_remote_retrieve_response_code( $response ); | ||
| if ( 200 === $status_code ) { | ||
| // Save the thumbnail. | ||
| $this->save_thumbnail( $file_id, $contents ); |
There was a problem hiding this comment.
Also get_thumbnail_url function should return cached URL if network request fails. If all the network requests fails, then at the end you can check whether the file of this ID is already cached, if it is then send that URL.
| </a> | ||
| <img src="<?php echo esc_url( $thumbnail_url ); ?>" alt="<?php esc_attr_e( 'Shared Document Preview', 'rt-google-embeds' ); ?>" style="border: 1px solid #eee; margin: 15px auto; display: block;" /> | ||
| </div> | ||
| if ( file_exists( $cached_file ) ) : ?> |
There was a problem hiding this comment.
There won't be a cached_file URL here, as if the network request fails, get_thumbnail_url function itself will return cached file URL.
There was a problem hiding this comment.
Instead of adding https://github.com/rtCamp/wp-google-drive/pull/6/files#diff-59c6e676df5dade9eec1de91f5c5b44fR252-R253 lines, you'll only use the URL retrieved from get_thumbnail_url function, that function will decide whether to use cached image or network image URL.
Whenever network request is successful, you update the cached image. And when network request fails, you return the cached image URL.
itowhid06
force-pushed
the
cache-preview-image
branch
from
3e1164b to
165a371
Compare
No description provided.