Ensure localStorage is not fired in the source window with IE9/10 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@thisiskylierose why did you close? |
|
I need to do some more testing on the changes first. |
|
Please have a look now - have tested these changes more with redux in a build and it seems to be working well. Need to run tests in IE9/10 to make sure those browsers play nice. :) |
|
Dev branch has console logs: https://github.com/thisiskylierose/redux-persist-crosstab/tree/development |
added 7 commits
December 3, 2015 10:36
|
This seems to be assuming the focused window is the source window. While that may be true for your specific application, it is not true in general. For example, we sometimes trigger redux updates as a result of an HTTP response, which may come in while a different window/tab is in focus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
HTML5 localStorage implementation in IE 9/10 does not match the spec. This is a known issue and the pull request addresses a work-around. Please test and feedback any changes required. See link below for more details on the problem.
https://connect.microsoft.com/IE/feedback/details/774798/localstorage-event-fired-in-source-window