Skip to content

Added ID argument for the box function #170

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Added ID argument for the box function #170

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7b00bef
adding the ID tag to the outmost div object in box() for a better con…
theGreatWhiteShark Dec 20, 2016
22474fb
adding the description of the ID argument
theGreatWhiteShark Dec 21, 2016
820baac
adding the id tag of the tab-box to the outmost div as well
theGreatWhiteShark Dec 21, 2016
24d680c
adding README to explain motivation behind forking
theGreatWhiteShark Jan 10, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions R/boxes.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,7 @@ infoBox <- function(title, value = NULL, subtitle = NULL,
#' the user to collapse the box.
#' @param collapsed If TRUE, start collapsed. This must be used with
#' \code{collapsible=TRUE}.
#' @param id ID of the outmost div object for a better handling in the CSS file.
#' @param ... Contents of the box.
#'
#' @family boxes
Expand Down Expand Up @@ -250,7 +251,8 @@ infoBox <- function(title, value = NULL, subtitle = NULL,
#' @export
box <- function(..., title = NULL, footer = NULL, status = NULL,
solidHeader = FALSE, background = NULL, width = 6,
height = NULL, collapsible = FALSE, collapsed = FALSE) {
height = NULL, collapsible = FALSE, collapsed = FALSE,
id = NULL) {

boxClass <- "box"
if (solidHeader || !is.null(background)) {
Expand Down Expand Up @@ -301,6 +303,7 @@ box <- function(..., title = NULL, footer = NULL, status = NULL,
}

div(class = if (!is.null(width)) paste0("col-sm-", width),
id = ifelse( !is.null(id), id, paste0("col-sm-", width)),
div(class = boxClass,
style = if (!is.null(style)) style,
headerTag,
Expand Down Expand Up @@ -401,6 +404,7 @@ tabBox <- function(..., id = NULL, selected = NULL, title = NULL,
tags$li(class = paste("header", titleClass), title)
)
}

div(class = paste0("col-sm-", width), content)
if ( is.null( id ) )
id <- ""
div(class = paste0("col-sm-", width), content, id = id)
}
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# Why I did this fork?

Since I wanted the ID of a box to be set in the outmost div object and not somewhere in the third layer. Else I wouldn't be able to customize their behavior using CSS3.

Shiny Dashboard
===============

Expand Down
4 changes: 3 additions & 1 deletion man/box.Rd
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.