Skip to content

Support core metadata versions 2.3 and 2.4 #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 27, 2025

Conversation

andriygm
Copy link
Contributor

@andriygm andriygm commented Dec 9, 2024

closes #34

@jmwoliver
Copy link
Collaborator

@andriygm Thanks again for this contribution as well! It looks great, but do you know of a package that could be used to exercise this metadata in a test? If there is a public package we know uses that field, we could add it to the repo list here:

var repositories = []Repository{

Then the tests would verify that the fields from 2.3 and 2.4 behave the same as the latest twine version.

@jmwoliver
Copy link
Collaborator

I found a package that has updated to metadata 2.4 and have tested this locally. I'll go ahead and merge this in and write a test for it separately. Thanks again for the contribution!

@jmwoliver jmwoliver merged commit e19a468 into rstudio:main Jan 27, 2025
3 checks passed
@andriygm andriygm deleted the support-pep-639 branch January 28, 2025 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doesn't handle 2.4 metadata
2 participants