Add get verb to pods/attach in Connect service account role for new kubernetes backend#875
Merged
Conversation
plascaray
approved these changes
May 29, 2026
lucasrod16
reviewed
May 29, 2026
|
|
||
| ## 0.20.3 | ||
|
|
||
| - Add `get` on `pods/attach` to the direct Kubernetes runner Role in `templates/rbac.yaml` to support attach/exec authorization checks used by Kubernetes clients. |
Contributor
There was a problem hiding this comment.
Should we include a note in the NEWS about websocket support being the reason why we're adding this permission?
Comment on lines
109
to
112
| resources: | ||
| - "pods/exec" | ||
| verbs: | ||
| - "create" |
Contributor
There was a problem hiding this comment.
Will we also need get for pods/exec for killing jobs?
Contributor
Author
There was a problem hiding this comment.
Good catch, thanks!
Bump rstudio-connect chart version to 0.20.3 and update NEWS.md
dbkegley
force-pushed
the
kegs-fix-k8s-ws-rbac
branch
from
62a5068 to
0c1ada6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bump
rstudio-connectchart version to 0.20.3 and update NEWS.mdUpdate the rstudio-connect chart service account RBAC to allow websocket connections which are used by the kubernetes backend to execute jobs remotely on k8s. Connect 2026.04 correctly falls back to SPDY on websocket connection upgrade failures. The missing RBAC ensured that all connections were falling back to SPDY.
Connect 2026.05.0 introduced a regression which prevented fallback to SPDY, meaning all steaming connections now fail (exec/attach). This PR allows the initial websocket connection to succeed. The next release of Connect will fix the SPDY fallback