Skip to content

fix: test rstest examples when run rslib / rsbuild eco-ci #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
9aoy merged 1 commit into from
Mar 27, 2026
Merged

fix: test rstest examples when run rslib / rsbuild eco-ci #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/rsbuild/rstest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ export async function test(options: RunOptions) {
repo: 'web-infra-dev/rstest',
branch: process.env.RSTEST ?? 'main',
// ignore snapshot changes
test: ['test -u'],
test: ['test -u', 'test:examples'],
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Adding the test:examples script likely requires webkit to be installed for Playwright, as is done in tests/rspack/rstest.ts. The beforeTest hook on line 12 only installs chromium, which may cause test:examples to fail.

To ensure consistency and prevent potential failures, please consider updating the beforeTest hook to also install webkit:

// tests/rsbuild/rstest.ts:11-13
beforeTest: async () => {
  await $`pnpm exec playwright install chromium webkit --with-deps`;
},

beforeTest: async () => {
await $`pnpm exec playwright install chromium --with-deps`;
},
Expand Down
2 changes: 1 addition & 1 deletion tests/rslib/rstest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ export async function test(options: RunOptions) {
...options,
repo: 'web-infra-dev/rstest',
branch: process.env.RSTEST ?? 'main',
test: ['test'],
test: ['test', 'test:examples'],
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot Mar 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

Adding the test:examples script likely requires webkit to be installed for Playwright, as is done in tests/rspack/rstest.ts. The beforeTest hook on line 11 only installs chromium, which may cause test:examples to fail.

To ensure consistency and prevent potential failures, please consider updating the beforeTest hook to also install webkit:

// tests/rslib/rstest.ts:10-12
beforeTest: async () => {
  await $`pnpm exec playwright install chromium webkit --with-deps`;
},

beforeTest: async () => {
await $`pnpm exec playwright install chromium --with-deps`;
},
Expand Down
Loading