Skip to content

test: fix missing runtime deps#155

Merged
chenjiahan merged 2 commits intomainfrom
fix_mf_dep_0311
Mar 11, 2026
Merged

test: fix missing runtime deps#155
chenjiahan merged 2 commits intomainfrom
fix_mf_dep_0311

Conversation

@chenjiahan
Copy link
Member

@chenjiahan chenjiahan commented Mar 11, 2026

Copilot AI review requested due to automatic review settings March 11, 2026 04:29
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses missing runtime dependencies by performing a targeted upgrade of core Rspack packages and integrating necessary Module Federation runtime tools. These changes ensure that the project's test environment is correctly configured and that all dependencies are up-to-date for stable operation.

Highlights

  • Dependency Upgrades: Upgraded @rspack/core and @rspack/cli to version 2.0.0-beta.6 across the project, including the example application.
  • New Test Dependency: Added @module-federation/runtime-tools as a development dependency specifically for the test suite to address missing runtime dependencies.
  • Lockfile Synchronization: Synchronized the pnpm-lock.yaml file to reflect all updated Rspack package versions and the newly introduced Module Federation runtime tools and their transitive dependencies.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • example/package.json
    • Updated @rspack/cli and @rspack/core to 2.0.0-beta.6.
  • package.json
    • Updated @rspack/core to 2.0.0-beta.6.
  • pnpm-lock.yaml
    • Updated various @rspack package bindings and resolutions to 2.0.0-beta.6.
    • Added @module-federation/runtime-tools and its associated packages as new dependencies.
    • Adjusted dependency graphs to include @module-federation/runtime-tools in relevant packages like @rsbuild/core and @rstest/core.
  • tests/package.json
    • Added @module-federation/runtime-tools as a development dependency.
Activity
  • No specific human activity (comments, reviews) has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request upgrades @rspack/core, @rspack/cli, and related bindings to version 2.0.0-beta.6, and adds @module-federation/runtime-tools as a development dependency for tests. These changes, confined to package.json and pnpm-lock.yaml files, are consistent with the stated goal of fixing missing runtime dependencies for tests and appear to be correct.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the test/example toolchain to align with @rspack/* 2.0.0-beta.6 and ensures module federation runtime tooling is available so the repository’s test suite can run without missing peer/runtime dependencies.

Changes:

  • Bump @rspack/core (root) and @rspack/cli/@rspack/core (example) to 2.0.0-beta.6.
  • Add @module-federation/runtime-tools to the tests workspace devDependencies to satisfy runtime needs during federation-related tests.
  • Refresh pnpm-lock.yaml accordingly (including new @module-federation/* entries and updated rspack bindings).

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
tests/package.json Adds @module-federation/runtime-tools to support module federation tests.
package.json Updates root devDependency @rspack/core to 2.0.0-beta.6.
example/package.json Updates example tooling to @rspack/* 2.0.0-beta.6.
pnpm-lock.yaml Lockfile updates reflecting the new rspack version and added federation runtime packages.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@chenjiahan chenjiahan enabled auto-merge (squash) March 11, 2026 04:36
@chenjiahan chenjiahan disabled auto-merge March 11, 2026 05:21
@chenjiahan chenjiahan merged commit 6e7750e into main Mar 11, 2026
3 checks passed
@chenjiahan chenjiahan deleted the fix_mf_dep_0311 branch March 11, 2026 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants