Skip to content

fix: update peerDependencies to support Rsbuild v2 #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
chenjiahan merged 1 commit into from
Jan 15, 2026
Merged

fix: update peerDependencies to support Rsbuild v2 #30

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@
"typescript": "^5.9.3"
},
"peerDependencies": {
"@rsbuild/core": "1.x"
"@rsbuild/core": "^1.0.0 || ^2.0.0-0"
Copy link

Copilot AI Jan 15, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version range ^2.0.0-0 will match any v2 pre-release version (2.0.0-alpha.0, 2.0.0-beta.1, etc.) and all v2 stable versions. However, this approach is risky without testing against actual v2 releases, as major version bumps typically include breaking changes. Consider using a more conservative range like ^1.0.0 || >=2.0.0-0 <3.0.0 or testing with v2 pre-releases before adding support. Alternatively, update the devDependency @rsbuild/core to a v2 pre-release version and run the test suite to verify compatibility.

Suggested change
"@rsbuild/core": "^1.0.0 || ^2.0.0-0"
"@rsbuild/core": "^1.0.0 || >=2.0.0-0 <3.0.0"

Copilot uses AI. Check for mistakes.
},
"peerDependenciesMeta": {
"@rsbuild/core": {
Expand Down