StableSet fork merge #92
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atures - Added a StableSet implementation, as a base class for OrderedSet. - Added Many functions to OrderedSet, to be more complete and more compatible with other implementations. - popitem(last: bool = True), similar to `dict.popitem` (note minor incompatibility with another implementation (`orderedset`) that have the `last` keyword in the `pop` function) - move_to_end(key), similar to `dict.move_to_end` - __le__, __lt__, __ge__, __gt__ - to improve subset/superset testing - Minimum Python version is 3.8 (because __reversed__) - Fix: OrderedSet.update now raised a TypeError instead of a ValueError when the type of the input is incorrect
…ils from __init__.py
test/__init__.py added
…ts to test multiple set types
…m/simonpercivall/orderedset/blob/master/tests/test_orderedset.py to test against multiple set types
…/bustawin/ordered-set-37/blob/master/test/test_testing.py to test against multiple set types
|
I can see why these would be desired features, but I don't want to increase the scope of this library. I'd have no ill will if you just released and packaged your own fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #91
dict.popitem(note minor incompatibility with another implementation (orderedset) that have thelastkeyword in thepopfunction)dict.move_to_end