-
-
Notifications
You must be signed in to change notification settings - Fork 1k
Fix parameter matching with mail delivery job and ActionMailer::MailDeliveryJob
#2516
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
fabn
wants to merge
6
commits into
rspec:main
from
fabn:fix-parameter-matching-with-mail-delivery-job
Closed
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
018fd01
Change HaveEnqueuedEmail to work as usual in Rails 6
fabn ce40ff4
Add missing relish documentation for parameter matching
fabn 3751e49
Ensure ActionMailer::MailDeliveryJob is defined
fabn c4b8f79
Silence rubocop for HaveEnqueuedMail class length
fabn 96f323e
Split all syntax in different examples
fabn 023df8a
Clarify examples with better params usage
fabn File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -38,3 +38,40 @@ Feature: have_enqueued_mail matcher | |
""" | ||
When I run `rspec spec/mailers/user_mailer_spec.rb` | ||
Then the examples should all pass | ||
|
||
Scenario: Checking mailer arguments | ||
Given a file named "app/mailers/my_mailer.rb" with: | ||
"""ruby | ||
class MyMailer < ApplicationMailer | ||
|
||
def signup(user = nil) | ||
@user = user | ||
|
||
mail to: "[email protected]" | ||
end | ||
end | ||
""" | ||
Given a file named "spec/mailers/my_mailer_spec.rb" with: | ||
"""ruby | ||
require "rails_helper" | ||
|
||
RSpec.describe MyMailer do | ||
it "matches with enqueued mailer" do | ||
ActiveJob::Base.queue_adapter = :test | ||
# Works with plain args | ||
expect { | ||
MyMailer.signup('user').deliver_later | ||
}.to have_enqueued_mail(MyMailer, :signup).with('user') | ||
# Works with named parameters | ||
expect { | ||
MyMailer.with('foo' => 'bar').signup.deliver_later | ||
}.to have_enqueued_mail(MyMailer, :signup).with('foo' => 'bar') | ||
# Works also with both, named parameters match first argument | ||
pirj marked this conversation as resolved.
Show resolved
Hide resolved
|
||
expect { | ||
MyMailer.with('foo' => 'bar').signup('user').deliver_later | ||
pirj marked this conversation as resolved.
Show resolved
Hide resolved
|
||
}.to have_enqueued_mail(MyMailer, :signup).with({'foo' => 'bar'}, 'user') | ||
end | ||
end | ||
""" | ||
When I run `rspec spec/mailers/my_mailer_spec.rb` | ||
Then the examples should all pass |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.