Skip to content

Explicitly list Ruby/Rails combinations in .travis.yml #2000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Explicitly list Ruby/Rails combinations in .travis.yml #2000

wants to merge 1 commit into from

Conversation

brian-kephart
Copy link
Contributor

This PR separates out some of the changes originally included in #1998. Instead of applying inclusions and exclusions to an auto-generated matrix, now every Ruby/Rails combination to be tested is explicitly listed.

Other changes:

  1. Patch version bumps
  2. Specific versions changed to tilde version specifiers
  3. Tests for Ruby < 2.4 not tested against Rails master, which now requires Ruby 2.4+

@JonRowe
Copy link
Member

JonRowe commented Jun 20, 2018

I appreciate the enthusiasm with the extra builds, but I was hoping for the build matrix to remain the same bar version upgrades! Note the deliberate 2.x builds where because travis automatically picks the latest, that said I'm happy to replace them with FQ'd versions.

@JonRowe
Copy link
Member

JonRowe commented Jun 20, 2018

I'd love to get a green build matrix here to, I believe it's just Rake causing problems on certain combinations again which can be resolved with the Gemfile.

@brian-kephart
Copy link
Contributor Author

Please note that there's a pre-existing issue here. The first time I cloned master and ran a Travis build on my account with no changes, the issue with rake appeared. If you look at the first two failures in the list, rake installs correctly from the Gemfile the first time, then when gems are reinstalled from the build script the wrong version is retrieved. This happened to me repeatedly, always on different jobs in the build (seemingly at random), and in each case the job completed successfully when I re-ran it.

Again, this happened BEFORE I made any changes. Attempting to resolve it via the Gemfile was not successful. I suspect the problem is actually here, but a few attempts to fix it here weren't successful either.

I haven't seen the rake issue in the final build job before. No idea about that one.

@JonRowe
Copy link
Member

JonRowe commented Jun 21, 2018

Closing in favour of #2001, thanks for your time and effort here!

@JonRowe JonRowe closed this Jun 21, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants