-
-
Notifications
You must be signed in to change notification settings - Fork 1k
RFC: versioning strategy #1967
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: versioning strategy #1967
Conversation
👍
It's worth calling out that we're discussing changing this for RSpec (see rspec/rspec#25). Not sure what affect (if any) that should have on rspec-rails, though. |
I entirely support this, my only comment is how will |
This depends on the details of how RSpec majors get released, the intent is to move RSpec Rails to public API of RSpec, so I suspect when RSpec goes through a major that actually affects the API, we'll need to support both versions. This will be a good test to make sure our plugin api is powerful enough to actually support an extension of the magnitude of RSpec Rails. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I think we can consider this accepted. Merging. |
view rendered
Please leave comments on the PR. The render link will update as new commits get pushed.