Skip to content

RFC: versioning strategy #1967

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 12, 2019
Merged

RFC: versioning strategy #1967

merged 1 commit into from
May 12, 2019

Conversation

fables-tales
Copy link
Member

view rendered

Please leave comments on the PR. The render link will update as new commits get pushed.

@myronmarston
Copy link
Member

👍

For the purposes of this versioning strategy, we consider removing a Rails or Ruby version to be a breaking change.

It's worth calling out that we're discussing changing this for RSpec (see rspec/rspec#25). Not sure what affect (if any) that should have on rspec-rails, though.

@JonRowe
Copy link
Member

JonRowe commented Mar 17, 2018

I entirely support this, my only comment is how will rspec-rails handle major releases of RSpec going forward, and what affect if any RSpec dropping ruby version support (as discussing in rspec/rspec#25) have on this? (I think none as Rails only supports in life Ruby?)

@fables-tales
Copy link
Member Author

This depends on the details of how RSpec majors get released, the intent is to move RSpec Rails to public API of RSpec, so I suspect when RSpec goes through a major that actually affects the API, we'll need to support both versions. This will be a good test to make sure our plugin api is powerful enough to actually support an extension of the magnitude of RSpec Rails.

Copy link
Contributor

@BobbyMcWho BobbyMcWho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fables-tales
Copy link
Member Author

I think we can consider this accepted. Merging.

@fables-tales fables-tales merged commit f34c39e into master May 12, 2019
@JonRowe JonRowe deleted the rfc-versioning-strategy branch May 13, 2019 10:14
benoittgt pushed a commit that referenced this pull request May 13, 2019
00dav00 pushed a commit to 00dav00/rspec-rails that referenced this pull request Jun 5, 2019
benoittgt pushed a commit to benoittgt/rspec-rails that referenced this pull request Aug 21, 2019
benoittgt pushed a commit to benoittgt/rspec-rails that referenced this pull request Aug 24, 2019
benoittgt pushed a commit that referenced this pull request Aug 24, 2019
benoittgt pushed a commit to benoittgt/rspec-rails that referenced this pull request Aug 27, 2019
JonRowe pushed a commit that referenced this pull request Oct 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants