Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

provides essential info on the project #1

Merged
merged 3 commits into from
Nov 16, 2020

Conversation

iychche
Copy link
Contributor

@iychche iychche commented Nov 13, 2020

No description provided.

@OlegDokuka
Copy link
Member

OlegDokuka commented Nov 13, 2020

@iychche I set up the DCO check, please make sure your commit is signed. (it is organization policy to sign that you have rights to contribute)

Also, it worth mentioning that the implementation is planned for the client-side only (or both?)

Best,
Oleh

@OlegDokuka
Copy link
Member

OlegDokuka commented Nov 13, 2020

Also, it would be great to have an initial discussion through something like Road Map issue including all the steps needed for the implementation (e.g. rsocket/rsocket-kotlin#115). Following PRs or discussions may be done in the separate Github issue but being referenced in the Road Map one for clarity.

Following such a format will help to understand what is implemented as well as discuss all the details without the need to update readme every time in case something has changed. Alternatively, the GitHub wiki can be used https://github.com/rsocket/rsocket-swift/wiki

@gabeb-intu
Copy link
Collaborator

@iychche I set up the DCO check, please make sure your commit is signed. (it is organization policy to sign that you have rights to contribute)

Also, it worth mentioning that the implementation is planned for the client-side only (or both?)

Best,
Oleh

We are only planning to implement for client side for now

@gabeb-intu
Copy link
Collaborator

Also, it would be great to have an initial discussion through something like Road Map issue including all the steps needed for the implementation (e.g. rsocket/rsocket-kotlin#115). Following PRs or discussions may be done in the separate Github issue but being referenced in the Road Map one for clarity.

Following such a format will help to understand what is implemented as well as discuss all the details without the need to update readme every time in case something has changed. Alternatively, the GitHub wiki can be used https://github.com/rsocket/rsocket-swift/wiki

I like the wiki approach but we will discuss with the team and get back to you

@OlegDokuka
Copy link
Member

@gabeb-intu do not treat it as something you mandated to do. It is just my advice from my experience

Signed-off-by: ciychodianda <[email protected]>
Signed-off-by: ciychodianda <[email protected]>
Signed-off-by: ciychodianda <[email protected]>
@OlegDokuka OlegDokuka changed the title updating Readme with approach provides essential info on the project Nov 16, 2020
@OlegDokuka OlegDokuka merged commit 4b65d8e into rsocket:main Nov 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants