Skip to content

New storage cells in Bridge native contract for base and super events info #3350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 44 commits into from
Oct 23, 2025
Merged

New storage cells in Bridge native contract for base and super events info #3350

merged 44 commits into from
Oct 23, 2025

Conversation

@marcos-iov
Copy link
Contributor

Implementation of RSKIP529

Description

  • Implementation of RSKIP529
  • Add 2 new storage cells in the native Bridge contract to store information of base and super events
  • Include get/set/clear methods for each. set/clear con only be called by the Union Bridge contract address

Motivation and Context

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • Tests for the changes have been added (for bug fixes / features)
  • Requires Activation Code (Hard Fork)
  • Other information:

@marcos-iov marcos-iov requested a review from a team as a code owner October 9, 2025 19:17
@github-actions
Copy link

github-actions bot commented Oct 9, 2025 •
edited
Loading

Dependency Review

✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.

Scanned Files

None

@marcos-iov marcos-iov force-pushed the refactor-addressBasedAuthorizer-integration branch from 5cdabd3 to 244a503 Compare October 10, 2025 18:57
@marcos-iov marcos-iov force-pushed the super_events_integration branch from 548bbb3 to 9ee6781 Compare October 10, 2025 19:02
Base automatically changed from refactor-addressBasedAuthorizer-integration to union-bridge-integration October 13, 2025 18:56
@marcos-iov marcos-iov force-pushed the super_events_integration branch from 5c1d8dd to ba24c39 Compare October 13, 2025 19:08
Base automatically changed from union-bridge-integration to master October 17, 2025 15:05
@marcos-iov marcos-iov force-pushed the super_events_integration branch 3 times, most recently from b387bba to 6000a3f Compare October 22, 2025 18:58
@julia-zack @marcos-iov
Add RSKIP529 config
86ff45b
@julia-zack @marcos-iov
Add super event authorizer to union bridge constants
e4e544f
@julia-zack @marcos-iov
Add SUPER_EVENT index key
63c4f38
@julia-zack @marcos-iov
Add deserializer method to return empty array when null data
db44807
@julia-zack @marcos-iov
Add union bridge storage provider impl
ae897ed
@julia-zack @marcos-iov
Add union bridge support impl
d10c6e6
@julia-zack @marcos-iov
Add bridge support method to call union bridge ones
ecd3e5f
@julia-zack @marcos-iov
Add Bridge Methods
c029c00
@julia-zack @marcos-iov
Add missing RSKIP529 config for getReed801Rskips
9e4fa2c
@julia-zack @marcos-iov
Remove unnecessary des_serializer methods for super event data
54f9787
@julia-zack @marcos-iov
Remove business logic of empty data from storage provider
e6430fb
@julia-zack @marcos-iov
Save null in storage when clearing super event value
83d0daf
@julia-zack @marcos-iov
Return empty array from support when empty data from provider
acde190
@julia-zack @marcos-iov
Replace declaration of emptyArray for ByteUtil.EMPTY_BYTE_ARRAY
165d1dd
@julia-zack @marcos-iov
Add TODOs for gas cost in new methods
66244b5
@julia-zack @marcos-iov
Add data length in error message
5756b7e
@julia-zack @marcos-iov
Remove superEventAuthorizer from constants
ef3d53f
@julia-zack @marcos-iov
Move authorization checks to union support
a672ba8
@julia-zack @marcos-iov
Remove checks at bridge level. Add tests for bridge support
6232bcf
@julia-zack @marcos-iov
Remove last use of emptyArray
3444d36
julia-zack and others added 23 commits October 23, 2025 09:46
@julia-zack @marcos-iov
Refactor storage provider so getter does not return Optional
3180e97
@julia-zack @marcos-iov
Create validate method that throws to remove duplicated code. Refacto…
e2d9940 
…r method so boolean condition is not always inverted
@marcos-iov
Avoid handling null values as super event
d358f26
@marcos-iov
Clean up setSuperEvent method
2ddf575
@julia-zack @marcos-iov
Add BASE_EVENT storage index key
2eb9a11
@julia-zack @marcos-iov
Add set, get and clear base event methods in storage provider
bb13a89
@julia-zack @marcos-iov
Add set, get and clear base event methods in support
b498e7d
@julia-zack @marcos-iov
Add methods in bridge support to call union ones
2f6c069
@julia-zack @marcos-iov
Add methods to Bridge
da6c061
@julia-zack @marcos-iov
Refactor storage provider so getter does not return Optional
e2aa63e
@julia-zack @marcos-iov
Import EMPTY_BYTE_ARRAY constant
0e9c00a
@marcos-iov
Simplify base events logic
fc15f72
@marcos-iov
Add RSKIP529 to ActivationConfigTest
2a0e6c4
@marcos-iov
Cleanup BridgeTest
539135b
@julia-zack @marcos-iov
Add requireNonNull check to support layer also
710424c
@julia-zack @marcos-iov
Refactor and cleaning up tests
8d31a22
@julia-zack @marcos-iov
Refactor to check data is not null before everything else
58ac28d
@marcos-iov
Fix tests post rebase
f05e22c
@marcos-iov
Extract event data length validation to its own method
45e7fd2
@marcos-iov
Use SolidityType enum for new methods definition
1fc9cda
@marcos-iov
Set gas cost for new Bridge methods to get/set super/base events info
cdd986b
@marcos-iov
Set RSKIP529 as part of Vetiver
aed8c70
@marcos-iov
Add RSKIP529 as part of Reed 8.1.0
e940f01
@marcos-iov marcos-iov force-pushed the super_events_integration branch 2 times, most recently from 6a75e80 to e940f01 Compare October 23, 2025 15:31
@sonarqubecloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
42 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@josedahlquist josedahlquist merged commit 91bd19f into master Oct 23, 2025
25 of 27 checks passed
@marcos-iov marcos-iov deleted the super_events_integration branch October 23, 2025 17:50
@aeidelman aeidelman added this to the Reed 8.1.0 milestone Oct 31, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@julia-zack julia-zack julia-zack approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

Reed 8.1.0

Development

Successfully merging this pull request may close these issues.

5 participants

@marcos-iov @julia-zack @josedahlquist @aeidelman