Skip to content

Conversation

rmoreliovlabs
Copy link

Removed duplicated classes already existing in co.rsk:native:

  • core/src/main/java/org/bitcoin/NativeSecp256k1.java
  • core/src/main/java/org/bitcoin/NativeSecp256k1Util.java
  • core/src/main/java/org/bitcoin/Secp256k1Context.java

@rmoreliovlabs rmoreliovlabs force-pushed the remove-duplicate-libraries branch 3 times, most recently from 2c6a156 to a1b912b Compare February 18, 2022 03:32
Vovchyk
Vovchyk previously approved these changes Feb 22, 2022
josedahlquist
josedahlquist previously approved these changes Feb 23, 2022
@rmoreliovlabs rmoreliovlabs dismissed stale reviews from josedahlquist and Vovchyk via a0fcdb1 March 29, 2022 05:03
@rmoreliovlabs rmoreliovlabs force-pushed the remove-duplicate-libraries branch from a1b912b to a0fcdb1 Compare March 29, 2022 05:03
Copy link

@josedahlquist josedahlquist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add to .gitignore the .DS_STORE files? and remove them from your PR?

@rmoreliovlabs rmoreliovlabs force-pushed the remove-duplicate-libraries branch from 73bddc8 to a987d17 Compare April 6, 2022 13:39
@rmoreliovlabs
Copy link
Author

Done @josedahlquist

@Vovchyk Vovchyk requested a review from josedahlquist July 4, 2022 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants