Remove get ast node #88
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 14, 2017 12:40
It's not entirely claer what getASTNode() returns.
Is this a single node? Many unfamiliar with ASTs
might assume that it's an `{op: ..., lhs: ...,
rhs: ...}` which maps to this example, but in the
subsequent exaple the node contains another node
which isn't immediately evident and which makes
the example more complex to grasp.
It's not entirely claer what getASTNode() returns.
Is this a single node? Earlier examples introduce
that AST nodes are `{op: ..., lhs: ...,
rhs: ...}` which doesn't conform to this example
(where there is nesting). Be explicit.
TravkinAlex
approved these changes
Dec 20, 2017
|
You are using ES6 fat arrow operators in the ES5 code snippets. This cannot be right. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per lukehoban/es6features#107, the
getASTNode()confuses learning. Provide a concreteObject.