Skip to content
This repository was archived by the owner on Sep 22, 2022. It is now read-only.

feat: add links to offchain::ipfs and http tutorial #11

Merged
merged 4 commits into from
Nov 10, 2020

Conversation

niklaslong
Copy link
Member

@niklaslong niklaslong commented Oct 30, 2020

First quick prototyping, still missing a link for the http tutorial (will be added once merged). Adjusted the link colour to a slightly darker hue for contrast on the green.

Closes #10.

Screenshot 2020-10-30 at 16 43 46

@aphelionz
Copy link
Contributor

Awesome, can you include a screenshot in the PR description?

@niklaslong
Copy link
Member Author

niklaslong commented Oct 30, 2020

I also (very quickly) played around with the colours on another branch, not sure if this is open for discussion (if it isn't feel free to ignore this 😉) but thought I'd share:

Screenshot 2020-10-30 at 17 28 33

Copy link
Contributor

@aphelionz aphelionz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I think we can merge as-is. Just one very quick question.

@niklaslong
Copy link
Member Author

I've added the future link to the getting started guide, we'll need to merge rs-ipfs/rust-ipfs#420 as well. I've also changed to a ul.

@niklaslong niklaslong marked this pull request as ready for review October 30, 2020 18:10
@aphelionz
Copy link
Contributor

Oh! One more thing - either move that accessibility link "back to top" to under the further reading section, or add a new one there

@niklaslong
Copy link
Member Author

Ah, good catch—done ✅

@aphelionz aphelionz merged commit 5d26a6c into rs-ipfs:master Nov 10, 2020
@niklaslong niklaslong deleted the 10-links branch November 10, 2020 14:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IA: Where to put a couple links?
2 participants