Skip to content

Conversation

@chenyao36
Copy link

@chenyao36 chenyao36 commented Feb 5, 2024

Important diff to support zsh:

-if [ "$(jobs)" == "" ]
+if [[ "$(jobs)" = "" ]]

-    ENVRC_LOAD="{rc_found}" ENVRC_PPID=$$ $BASH
+    ENVRC_LOAD="{rc_found}" ENVRC_PPID=$$ $SHELL

Other diff:

  • change: envrc bash -> envrc hook;
  • new: envrc init bash and envrc init zsh;
  • refactor: cargo fmt; clap 2 builder -> clap 4 derive;

Copy link

@runlevel5 runlevel5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@roxma
Copy link
Owner

roxma commented Jul 11, 2024

This PR breaks existing config. I don't want to merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants