-
Notifications
You must be signed in to change notification settings - Fork 189
Use rmw_test_fixture to isolate ros2cli tests (backport #1062) #1106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: kilted
Are you sure you want to change the base?
Conversation
Signed-off-by: Scott K Logan <[email protected]> (cherry picked from commit 75e004a)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
* Enable RMW isolation for ros2doctor.test_report. Signed-off-by: Tomoya Fujita <[email protected]> * ResetEnvironment on shutdown is missing. Signed-off-by: Tomoya Fujita <[email protected]> * Clean up isolated ros2 daemon process when tests complete. Signed-off-by: Tomoya Fujita <[email protected]> * Clean up isolated ros2 daemon process for ros2topic. Signed-off-by: Tomoya Fujita <[email protected]> * Clean up isolated ros2 daemon process for ros2action. Signed-off-by: Tomoya Fujita <[email protected]> * Clean up isolated ros2 daemon process for ros2doctor. Signed-off-by: Tomoya Fujita <[email protected]> * Clean up isolated ros2 daemon process for ros2lifecycle and ros2node. Signed-off-by: Tomoya Fujita <[email protected]> * Clean up isolated ros2 daemon process for ros2param. Signed-off-by: Tomoya Fujita <[email protected]> --------- Signed-off-by: Tomoya Fujita <[email protected]>
@fujitatomoya I'll do a couple of extra attempts before giving up on replicating it. Tricky part would be trying to reproduce it on ci.ros2.org since the job with the regression it's on build.ros2.org. I added to this PR the commit that you referenced, I'm not sure if I'm missing something from the commits that were in the middle of those two but I will give a check in a bit. |
Re-running with extra commit from #1098 backported |
I was able to replicate the problem locally using the git clone [email protected]:ros-infrastructure/ros_buildfarm.git
cd ros_buildfarm/scripts/ci/
./generate_ci_script.py https://raw.githubusercontent.com/ros2/ros_buildfarm_config/ros2/index.yaml kilted nightly-release ubuntu noble amd64 > ci_job_kilted_all.sh
sh ci_job_kilted_all.sh I'm taking a look to see how to modify the generated script to get access to the docker environment running the tests, and troubleshoot what's left open when the tests are run. |
Description
Use the
rmw_test_isolation
system for creating a communication sandbox for each test.Fixes # (issue)
Is this user-facing behavior change?
Yes,
ros2cli.helpers.get_rmw_additional_env
will no longer enable multicast for Zenoh.Did you use Generative AI?
No
This is an automatic backport of pull request #1062 done by [Mergify](https://mergify.com).