In setuptools packages, install everything in launch directory (backport #5156) #5171
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
Signed-off-by: Emerson Knapp <[email protected]> Signed-off-by: Emerson Knapp <[email protected]> Co-authored-by: Christophe Bedard <[email protected]> (cherry picked from commit d002d60)
|
HTML artifacts: https://github.com/ros2/ros2_documentation/actions/runs/14064836700/artifacts/2817288472. To view the resulting site:
|
christophebedard
approved these changes
Mar 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #5143
Instead of using "clever" glob pattern to match
launch.xml,launch.yaml,launch.py- just copy what we already recommend for CMake packages, and install everything fromlaunch/directory. Benefit of consistency between package types, and potentially leaving the door open for other launch suffixes/frontends.(also, make our usage of
globconsistent across the repo - we were some places usingos.path.joininside it, and sometimes not. I opted for the simpler syntax)This is an automatic backport of pull request #5156 done by Mergify.