Skip to content

Conversation

@BMarchi
Copy link
Contributor

@BMarchi BMarchi commented Nov 12, 2019

Connected to ros2/ros2cli#390

As the title says, this PR provides an API to get the logging severity from a name in string format

@wuffle-ros wuffle-ros bot added the in review Waiting for review (Kanban column) label Nov 12, 2019
@BMarchi BMarchi requested a review from hidmic November 12, 2019 18:33
Signed-off-by: Brian Ezequiel Marchi <[email protected]>
Signed-off-by: Brian Ezequiel Marchi <[email protected]>
@BMarchi BMarchi force-pushed the BMarchi/add_test_for_ros2component branch from a90728a to f07421a Compare November 22, 2019 15:24
@BMarchi BMarchi requested a review from hidmic November 22, 2019 15:24
Signed-off-by: Brian Ezequiel Marchi <[email protected]>
@BMarchi BMarchi requested a review from hidmic November 25, 2019 13:11
Copy link
Contributor

@hidmic hidmic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending green CI

@BMarchi
Copy link
Contributor Author

BMarchi commented Nov 26, 2019

  • Linux Build Status
  • Arch Build Status
  • macOS Build Status
  • Windows Build Status

@BMarchi BMarchi merged commit 801996c into master Nov 26, 2019
@BMarchi BMarchi deleted the BMarchi/add_test_for_ros2component branch November 26, 2019 17:46
suab321321 pushed a commit to suab321321/rclpy that referenced this pull request Jan 31, 2020
* Provide logging severity for string

Signed-off-by: Brian Ezequiel Marchi <[email protected]>
Signed-off-by: AbhinavSingh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

in review Waiting for review (Kanban column)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants