Skip to content

Remove SHARED from pybind11_add_module (take two) to avoid segfaults on macOS with Python statically linked with libpython #1418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Remove SHARED from pybind11_add_module (take two) to avoid segfaults on macOS with Python statically linked with libpython #1418

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion rclpy/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,7 @@ function(configure_build_install_location _library_name)
endfunction()

# Split from main extension and converted to pybind11
pybind11_add_module(_rclpy_pybind11 SHARED
pybind11_add_module(_rclpy_pybind11
src/rclpy/_rclpy_logging.cpp
src/rclpy/_rclpy_pybind11.cpp
src/rclpy/action_client.cpp
Expand Down