-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Add computer_hw package (copied, improved from pr2_computer_monitor) #21
Open
130s
wants to merge
18
commits into
ros-drivers:kinetic
Choose a base branch
from
kinu-garage:feature-computer-monitor
base: kinetic
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
…ericity. Move all .launch files to conf folder.
…d so that diagnostics analyzer and other downstream utils ignore
…tially any container).
…parate vendor specific portions TODO fix unit test
5361360
to
f06bfe4
Compare
ae82cde
to
87b00b4
Compare
87b00b4
to
deb5cec
Compare
Unit test is failing and I think this is a bug in the unit test case.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The change in this PR is the same as #20 but re-opened from a different branch.
Issue aimed at
Changes
computer_hw
package (renamedpr2_computer_monitor
that was copied from pr2_robot repo).launch
to allow downstream to start processes by batch.Review items
Test
Dev test done on Ubuntu 16.04 host with nvidia GeForce GTX 1060
Sample of Diagnostic GUI with GPU monitoring output.
![](https://user-images.githubusercontent.com/1840401/150733767-fd4b9ffe-ad6e-44ce-97e1-20eef6ad2e30.png)