Make nodes runnable on Noetic #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… python3 Signed-off-by: Mikael Arguedas <[email protected]>
This is not compatible with python2 based distros because it looks like the "main" branch is only for Noetic Requires: ros/rosdistro#28495 Signed-off-by: Mikael Arguedas <[email protected]>
mikaelarguedas
force-pushed
the
python3-noetic-fixups-round1
branch
from
d15ea34 to
17c3141
Compare
|
@JWhitleyWork the rosdistro PR preventing this one from passing the tests has now been merged. This should be ready for review/merge now |
|
@JWhitleyWork friendly 🛎️ |
JWhitleyWork
approved these changes
Apr 27, 2021
|
Sorry for the delay. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the dependency listing and installation of python scripts so that they are compatible with Python3 that is used in ROS Noetic.
Depends on ros/rosdistro#28495
This PR does not include any fixes to the python code itself that may also not be compatible with python3 (e.g. #200)