Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[sound_play/scripts/soundplay_node.py] refactor code #86

Closed
wants to merge 1 commit into from
Closed

[sound_play/scripts/soundplay_node.py] refactor code #86

wants to merge 1 commit into from

Conversation

furushchev
Copy link
Contributor

from #77
In this pull request I only refactored code and remove unnecessary while loop.

@furushchev
Copy link
Contributor Author

friendly ping @trainman419

@furushchev
Copy link
Contributor Author

@trainman419 any update?

@trainman419
Copy link
Contributor

I'm waiting on #78 before I consider merging this.

@trainman419
Copy link
Contributor

This has conflicts and is generally out of date. Closing.

Please consider retargeting this to the master branch and include unit tests or some other test results that demonstrate that it does not break existing behavior.

@trainman419 trainman419 closed this May 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@furushchev @trainman419