Skip to content

Added volume control parameter at audio_capture/play #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

BeomsuHa
Copy link

@BeomsuHa BeomsuHa commented Apr 8, 2025

In sound play, there is a volume arg which can control the output volume
but in audio_capture and audio_play, there are no option to control the volume
So I added the volume parameter at audio_capture/audio_play as ~capture_volume/~play_volume

@knorth55
Copy link
Member

Thank you for your contribution!
I haven't checked this PR yet, but looks good.

Could you provide some video to show this feature if possible?
In that case, I don't need to check this PR with my local device

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants