Skip to content

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Aug 13, 2025

This PR migrates and enhances the chained_filter_controller originally implemented during the ROSCon 2024 control workshop. The controller enables chaining and filtering of state interfaces through a sequence of filters.

Changes introduced:

  1. Ported chained_filter_controller from workshop reference implementation.
  2. Developed unit tests covering:
    • Initialization and lifecycle behavior.
    • Filter configuration and chaining.
    • Correct propagation of state values through the filter stack.

This is an automatic backport of pull request #1634 done by [Mergify](https://mergify.com).

Co-authored-by: Christoph Froehlich <[email protected]>
(cherry picked from commit 228c586)

# Conflicts:
#	doc/release_notes.rst

This comment was marked as outdated.

@mergify mergify bot added the conflicts label Aug 13, 2025
Copy link

codecov bot commented Aug 13, 2025

Codecov Report

❌ Patch coverage is 92.35294% with 13 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.54%. Comparing base (61f26b1) to head (497d501).
⚠️ Report is 2 commits behind head on jazzy.

Files with missing lines Patch % Lines
chained_filter_controller/src/chained_filter.cpp 79.68% 9 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            jazzy    #1856      +/-   ##
==========================================
+ Coverage   85.45%   85.54%   +0.08%     
==========================================
  Files         133      137       +4     
  Lines       12998    13169     +171     
  Branches     1129     1139      +10     
==========================================
+ Hits        11108    11265     +157     
- Misses       1534     1543       +9     
- Partials      356      361       +5     
Flag Coverage Δ
unittests 85.54% <92.35%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ned_filter_controller/test/test_chained_filter.cpp 100.00% <100.00%> (ø)
...oller/test/test_load_chained_filter_controller.cpp 100.00% <100.00%> (ø)
...r_controller/test/test_multiple_chained_filter.cpp 100.00% <100.00%> (ø)
chained_filter_controller/src/chained_filter.cpp 79.68% <79.68%> (ø)

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit 848508d into jazzy Aug 13, 2025
14 of 15 checks passed
@christophfroehlich christophfroehlich deleted the mergify/bp/jazzy/pr-1634 branch August 13, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants