[JTC] Rename open_loop_control parameter and slightly change its scope #1525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
arne48,
bijoua29,
bmagyar,
christophfroehlich,
DasRoteSkelett,
erickisos and
Raivias
Thieso
changed the title
christophfroehlich
requested changes
Feb 4, 2025
There was a problem hiding this comment.
Thanks for your PR. However, we must not change the default behavior of existing setups. Your change would go into the stable jazzy release as well.
- please keep the old
open_loopparameter and add a deprecation warning if it is set to the non-default value (true) - if
open_loopis set to true, we still should deactivate theuse_closed_loop_pid_adapter_and override the setting ofinterpolate_from_desired_state - Mark deprecated code clearly, so we can remove that in the release after next.
- Please add a migration note and release note here.
joint_trajectory_controller/src/joint_trajectory_controller_parameters.yaml
Outdated
Show resolved
Hide resolved
christophfroehlich
changed the title
…rameters.yaml Co-authored-by: Christoph Fröhlich <[email protected]>
Co-authored-by: Christoph Fröhlich <[email protected]>
…ion and release notes
|
Thanks for the comments. This should be better now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1505