Skip to content

Fix typos and mistakes and improve grammar #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Moohan
Copy link

@Moohan Moohan commented Mar 3, 2025

No description provided.

@mpadge
Copy link
Member

mpadge commented Mar 6, 2025

Thanks @Moohan for your contribution, which we both encourage and appreciate. In this case, however, the PR includes too many changes for us to include straight off. A few of your suggestions and typo-fixes are good and helpful, but many of your suggestions are stylistic, and some go against our general style.

Feel free to retain your own record of all changes included here, but in the meantime could you please reduce the PR to the following reduced set of changes on line numbers:

  • 25
  • 64
  • 68
  • 80
  • 171
  • 216
  • 265 - a very important catch, thank you!
  • 269 - same!
  • 296
  • 297
  • 316
  • 318
  • 364
  • 370, 372, 373, but please re-insert line breaks after end of each sentence
  • 391
  • 397
  • 418

Thanks again for your contribution, which we'll definitely include once we're all in agreement here. Also note for future reference that no change is too small, and it is generally much easier for us to respond to smaller pull requests than ones of this size. Once we've reduced this one, you should feel free to suggest any additional changes via separate PRs.

@maelle
Copy link
Member

maelle commented Mar 13, 2025

👋 @Moohan is any help needed, for instance with the Git aspects of selecting part of the changes?

@Moohan
Copy link
Author

Moohan commented Mar 13, 2025

👋 @Moohan is any help needed, for instance with the Git aspects of selecting part of the changes?

@maelle Thanks, nope I'm happy to look over the comments and make changes 😄 . I'm away this week, I'll get back to this at some point next week hopefully!

@maelle
Copy link
Member

maelle commented Mar 14, 2025

Thank you!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants