[math] migrate old Makefiles to CMake and reenable non-covered tests#21890
[math] migrate old Makefiles to CMake and reenable non-covered tests#21890ferdymercury wants to merge 15 commits intoroot-project:masterfrom
Conversation
Test Results 22 files 22 suites 3d 4h 39m 13s ⏱️ For more details on these failures, see this check. Results for commit 5fd8c35. ♻️ This comment has been updated with latest results. |
Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
linev
left a comment
There was a problem hiding this comment.
There are three points in smatrix/test/ subdirectory:
- Do we need test reflex dictionaries
- Is linking with CLHEP library crucial, do it properly
- How to use old ROOT files stored in the directory
| target_link_directories(${testname} PRIVATE "${CLHEPBASE}/lib") | ||
| endif() | ||
| endif() | ||
| ROOT_ADD_TEST(smatrix-${testname} COMMAND ${testname} LABELS ${${testname}_LABELS}) |
There was a problem hiding this comment.
There are two ROOT files in the directory which were generated by the tests.
One should try use these files for tests.
Most probably one need to make custom ROOT_ADD_TEST commands providing file name as argument
There was a problem hiding this comment.
you mean checking that the result generated by the test is compatible with that reference?
they get recreated at every run. so i guess that reference was done on an old SLC3 and gcc3
No idea whether those things are relevant, I just reenabled something that was there. If not relevant, we should just delete the whole test :) |
Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
as suggested by linev Co-authored-by: ferdymercury <ferdymercury@users.noreply.github.com>
| if (DEFINED ENV{USE_REFLEX}) | ||
| REFLEX_GENERATE_DICTIONARY(GVTrackDict Track.h SELECTION TrackDict.xml) | ||
| else() | ||
| ROOT_GENERATE_DICTIONARY(GVTrackDict Track.h LINKDEF TrackLinkDef.h OPTIONS -inlineInputHeader) | ||
| endif() |
There was a problem hiding this comment.
I would either drop one or always run both.
| if (DEFINED ENV{USE_REFLEX}) | |
| REFLEX_GENERATE_DICTIONARY(GVTrackDict Track.h SELECTION TrackDict.xml) | |
| else() | |
| ROOT_GENERATE_DICTIONARY(GVTrackDict Track.h LINKDEF TrackLinkDef.h OPTIONS -inlineInputHeader) | |
| endif() | |
| REFLEX_GENERATE_DICTIONARY(GVTrackDictXml Track.h SELECTION TrackDict.xml) | |
| ROOT_GENERATE_DICTIONARY(GVTrackDict Track.h LINKDEF TrackLinkDef.h OPTIONS -inlineInputHeader) |
and also duplicate the test accordingly.
Split-off #21820 as requested by @pcanal and @linev