Skip to content

[CMake] Never add current binary dir to command in ROOT_ADD_TEST #20616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2025
+1 −4
Merged

[CMake] Never add current binary dir to command in ROOT_ADD_TEST #20616

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a22ce40
[CMake] Never add current binary dir to command in `ROOT_ADD_TEST`
guitargeek Dec 2, 2025
1c5372c
[roottest] Use `root` target file in `dotLibraries` test command
guitargeek Dec 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions cmake/modules/RootMacros.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1542,9 +1542,6 @@ function(ROOT_ADD_TEST test)
find_program(_exe ${_prg})
if(_exe) # if the command is found in the system, use it
set(_cmd ${_exe} ${ARG_COMMAND})
elseif(NOT IS_ABSOLUTE ${_prg}) # if not absolute, assume is found in current binary dir
set(_prg ${CMAKE_CURRENT_BINARY_DIR}/${_prg})
set(_cmd ${_prg} ${ARG_COMMAND})
else() # take as it is
set(_cmd ${_prg} ${ARG_COMMAND})
endif()
Expand Down
2 changes: 1 addition & 1 deletion roottest/root/rint/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ ROOTTEST_ADD_TEST(missingSymbol
if (NOT MSVC)
# ROOT-5843
ROOTTEST_ADD_TEST(dotLibraries
COMMAND root -b -q -l -e ".libraries"
COMMAND $<TARGET_FILE:root> -b -q -l -e ".libraries"
PASSREGEX "libRint")
endif()

Expand Down
Loading