Skip to content

Conversation

@guitargeek
Copy link
Contributor

@guitargeek guitargeek commented Nov 30, 2025

The new Keras 3 API broke the existing TMVA PyKeras method.

Also exercise the removal in some temporary commits, to check if removing PyKeras is sufficient to fix tmva-pymva.

Alternative to:

@guitargeek guitargeek self-assigned this Nov 30, 2025
@guitargeek guitargeek force-pushed the deprecate_pymva_keras branch 4 times, most recently from 3e5048f to c3387d7 Compare November 30, 2025 17:41
@github-actions
Copy link

github-actions bot commented Nov 30, 2025

Test Results

    22 files      22 suites   4d 8h 20m 11s ⏱️
 3 797 tests  3 795 ✅ 0 💤 2 ❌
81 547 runs  81 545 ✅ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit 8627576.

♻️ This comment has been updated with latest results.

@guitargeek guitargeek force-pushed the deprecate_pymva_keras branch 2 times, most recently from 4613b73 to 3dc068d Compare December 1, 2025 08:30
The new Keras 3 API broke the existing TMVA `PyKeras` method.
This should work now that the PyKeras method is removed
@guitargeek guitargeek force-pushed the deprecate_pymva_keras branch from 3dc068d to 8627576 Compare December 1, 2025 12:09
@guitargeek guitargeek changed the title [tmva][pymva] Deprecate TMVA PyKeras method [tmva][pymva] Ecercise removal of deprecated TMVA PyKeras method Dec 1, 2025
@guitargeek guitargeek changed the title [tmva][pymva] Ecercise removal of deprecated TMVA PyKeras method [tmva][pymva] Exercise removal of deprecated TMVA PyKeras method Dec 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant