fix: update show

romo4ko · Oct 27, 2024 · 615e364 · 615e364
1 parent e233ca2
commit 615e364
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/app/Http/Controllers/Api/UserController.php b/app/Http/Controllers/Api/UserController.php
@@ -26,7 +26,7 @@ public function teamIsCaptain(int $id): array
 
     public function show(int $id): array
     {
-        $user = User::query()->findOrFail($id);
+        $user = User::query()->find($id);
 
         return $this->userService->show($user);
     }

diff --git a/app/Services/Api/UserService.php b/app/Services/Api/UserService.php
@@ -17,9 +17,13 @@
 
 class UserService
 {
-    public function show(User $user): array
+    public function show(User|null $user): array
     {
-        return UserShowDTO::from($user)->toArray();
+        if ($user) {
+            return UserShowDTO::from($user)->toArray();
+        }
+
+        return [];
     }
 
     public function achievement(Team|null $team, User|null $user): array