Use Zeitwerk for loading components #634
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solnic
force-pushed
the
607-better-auto-registration
branch
4 times, most recently
from
b14bd90 to
2d9f2f2
Compare
solnic
commented
Jun 11, 2021
| # @api private | ||
| def loader | ||
| @loader ||= Loader.new(@auto_register[0], **(@auto_register[1] || {})) if @auto_register | ||
| end |
There was a problem hiding this comment.
The way Loader is handled along with this components hash is going to be refactored separately. So, please ignore this part here.
solnic
changed the title
solnic
force-pushed
the
607-better-auto-registration
branch
from
67400e0 to
69046a0
Compare
- Replace AutoRegistration with a new Loader that uses Zeitwerk - Deprecate `ROM::Setup#auto_registration` and move it to `rom/compat` Refs #607
solnic
force-pushed
the
607-better-auto-registration
branch
from
69046a0 to
f9fc522
Compare
flash-gordon
approved these changes
Jun 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This replaces AutoRegistration with a Loader that uses Zeitwerk. I'll open a separate PR once this is merged with the actual API improvements, what this PR does essentially, is providing a better and simpler implementation for loading components. Things like options and behavior still need to be improved.
TODO
AutoRegistrationinto a component loaderwhere each instance handles a specific component typeturned out a single loader is needed because zeitwerk can't handle multiple dirs that have the same parentSetup#auto_registrationintoSetup#auto_registerand refine its behavior to use the new loaderlib/relations/users.rbwhere the constant is actuallyMyNamespace::Users-it cannot and this is fine, because this is a weird use case that's completely non-standard so I'll move this behavior to a backward-compatibility "layer"silly me missed the fact that Zeitwerk actually supports passing "namespace" option to push_dir, so this use case is supported after allrom/compatfor backward-compatibility APIs.Something likesticking to plainROM.include(ROM::Compat[5.0])should sufficerequire "rom/compat"for nowon_loadhandling because it actually yields path too, so we can infer component type from this easily