Add price editing overview page #12
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
November 5, 2024 22:32
- same filters as original product list - allows editing purchasePrice, margin and sellingPrice - auto saves whenever a change occurs The initial search returns ES search objects, so the template is made to handle both ES and ED (which also means adjusting some components to handle both). ember-data records are fetched to be able to save the records with their changes, but also react on changes in the template. Data is shown the moment ES returns a response. ED records are loaded while the user can already see the table. Some helpers specified inside a model are moved out of it so these can be used by ES results too.
- show an icon depending on the state of saving the specific row. - queues changes, so user can do multiple actions (e.g. change inputPrice and margin)
- remove unused helpers - use svg-jar for icons - avoid jumping UI when clicking buttons in pricelist - add page-title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a page for editing prices inline. This can only be viewed by price-admins.
The inline editing will first show the returned data from mu-search and loads the records in the background so editing is possible. If a user tries to edit before the loading is done, it is "kept in a queue" and will save the change the moment the records are loaded. There is an indication if the saving was successful or not.
Some helper components are adjusted so they can also handle mu-search data.
The pages under
/productsare moved around so filter logic can be reused in this new page.Filter logic is in
products.list, with the original list of products set inproducts.list.indexand the new price list inproducts.list.prices.Templating syntax (.gjs file) is used as the inline editing needs a few components to work (alternative would be to create 4 extra files).