Skip to content

Commit

Permalink
fix(miner): Fix issue seen in prepare proposal (berachain#1396)
Browse files Browse the repository at this point in the history
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Introduced a new proposal system for validators to propose and process
blocks.
- Enhanced the EVMKeeper interface to support blockchain setup and state
plugin factory retrieval.
- Added a new interface for ABCI requests with methods for transaction
and blockchain state retrieval.
- Implemented a state plugin factory for creating and managing state
plugins.
- Updated the blockchain interface to manage state plugins more
effectively.

- **Improvements**
- Removed unnecessary methods from the App interface to streamline
blockchain interactions.
- Updated Miner type to integrate with the Ethereum miner and state
plugin factory.
- Enhanced the Keeper type in EVM module to support new host chain
interactions.
- Modified the blockchain and chain writer interfaces to include state
parameters in various methods.

- **Bug Fixes**
- Fixed issues in genesis state handling by correctly utilizing the
state plugin factory.
- Adjusted EndBlock and PrepareCheckState functions in the EVM module to
align with the Cosmos-SDK lifecycle.

- **Documentation**
- Translated project introductory information and core principles to
Korean.

- **Refactor**
  - Updated various Go files to use the new Go version 1.21.6.
- Simplified the chain and miner modules by removing redundant fields
and imports.
- Refined the EVM module to better manage gas metering and state
overrides.

- **Chores**
- Updated Go version in workflow actions and Dockerfiles for consistent
build environments.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->

---------

Co-authored-by: ocnc <[email protected]>
Co-authored-by: Cal Bera <[email protected]>
  • Loading branch information
3 people authored Jan 10, 2024
1 parent 0855077 commit 759c0b0
Show file tree
Hide file tree
Showing 53 changed files with 806 additions and 338 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/codeql.yml
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@
# fail-fast: false
# matrix:
# language: ["go"]
# versions: [1.21.5]
# versions: [1.21.6]
# # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ]
# # Use only 'java' to analyze code written in Java, Kotlin or both
# # Use only 'javascript' to analyze code written in JavaScript, TypeScript or both
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/daily.yml
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
docs:
strategy:
matrix:
go-version: [1.21.5]
go-version: [1.21.6]
python-version: [3.11.5]
runs-on: ubuntu-latest
steps:
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/e2e.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
matrix:
docker-type: [base] # Changed docker-version to docker-type for consistency with the Makefile
os: [polaris-linux-latest]
go-version: [1.21.5]
go-version: [1.21.6]
arch: [amd64] # Changed go-arch to arch for consistency with the Makefile
image-name: ["polard/base:v0.0.0"]
export-name: [base-image]
Expand Down Expand Up @@ -76,7 +76,7 @@ jobs:
namespace: [cosmos]
docker-type: [localnet] # Changed docker-version to docker-type for consistency with the Makefile
os: [polaris-linux-latest]
go-version: [1.21.5]
go-version: [1.21.6]
arch: [amd64] # Changed go-arch to arch for consistency with the Makefile
base-image: [base-image]
image-name: ["polard/localnet:v0.0.0"]
Expand Down Expand Up @@ -123,7 +123,7 @@ jobs:
strategy:
matrix:
os: [polaris-linux-latest]
go-version: [1.21.5]
go-version: [1.21.6]
base-image: [base-image]
runs-on: ${{ matrix.os }}
steps:
Expand Down Expand Up @@ -153,7 +153,7 @@ jobs:
matrix:
namespace: ["e2e", "localnet"]
os: [polaris-linux-latest]
go-version: [1.21.5]
go-version: [1.21.6]
base-image: [localnet]
runs-on: ${{ matrix.os }}
steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
matrix:
args: ["build", "lint", "test-unit-race", "test-unit-cover"]
os: [polaris-linux-latest]
go-version: [1.21.5]
go-version: [1.21.6]
runs-on: ${{ matrix.os }}
steps:
- name: Checkout
Expand Down
2 changes: 1 addition & 1 deletion build/scripts/main.mk
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ proto-build:
# Variables
DOCKER_TYPE ?= base
ARCH ?= arm64
GO_VERSION ?= 1.21.5
GO_VERSION ?= 1.21.6
IMAGE_NAME ?= polard
IMAGE_VERSION ?= v0.0.0
BASE_IMAGE ?= polard/base:$(IMAGE_VERSION)
Expand Down
4 changes: 2 additions & 2 deletions build/tools/go.mod
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ require (
github.com/golangci/golangci-lint v1.55.2
github.com/google/addlicense v1.1.1
github.com/matryer/moq v0.3.2
github.com/onsi/ginkgo/v2 v2.13.0
github.com/onsi/ginkgo/v2 v2.13.2
github.com/securego/gosec/v2 v2.18.2
github.com/vektra/mockery/v2 v2.34.1
)
Expand Down Expand Up @@ -106,7 +106,7 @@ require (
github.com/gin-gonic/gin v1.9.1 // indirect
github.com/go-chi/chi/v5 v5.0.10 // indirect
github.com/go-critic/go-critic v0.9.0 // indirect
github.com/go-logr/logr v1.2.4 // indirect
github.com/go-logr/logr v1.3.0 // indirect
github.com/go-logr/stdr v1.2.2 // indirect
github.com/go-ole/go-ole v1.3.0 // indirect
github.com/go-playground/locales v0.14.1 // indirect
Expand Down
12 changes: 6 additions & 6 deletions build/tools/go.sum
Original file line number Diff line number Diff line change
Expand Up @@ -292,8 +292,8 @@ github.com/go-logfmt/logfmt v0.4.0/go.mod h1:3RMwSq7FuexP4Kalkev3ejPJsZTpXXBr9+V
github.com/go-logfmt/logfmt v0.5.0/go.mod h1:wCYkCAKZfumFQihp8CzCvQ3paCTfi41vtzG1KdI/P7A=
github.com/go-logr/logr v1.2.2/go.mod h1:jdQByPbusPIv2/zmleS9BjJVeZ6kBagPoEUsqbVz/1A=
github.com/go-logr/logr v1.2.3/go.mod h1:jdQByPbusPIv2/zmleS9BjJVeZ6kBagPoEUsqbVz/1A=
github.com/go-logr/logr v1.2.4 h1:g01GSCwiDw2xSZfjJ2/T9M+S6pFdcNtFYsp+Y43HYDQ=
github.com/go-logr/logr v1.2.4/go.mod h1:jdQByPbusPIv2/zmleS9BjJVeZ6kBagPoEUsqbVz/1A=
github.com/go-logr/logr v1.3.0 h1:2y3SDp0ZXuc6/cjLSZ+Q3ir+QB9T/iG5yYRXqsagWSY=
github.com/go-logr/logr v1.3.0/go.mod h1:9T104GzyrTigFIr8wt5mBrctHMim0Nb2HLGrmQ40KvY=
github.com/go-logr/stdr v1.2.2 h1:hSWxHoqTgW2S2qGc0LTAI563KZ5YKYRhT3MFKZMbjag=
github.com/go-logr/stdr v1.2.2/go.mod h1:mMo/vtBO5dYbehREoey6XUKy/eSumjCCveDpRre4VKE=
github.com/go-ole/go-ole v1.2.6/go.mod h1:pprOEPIfldk/42T2oK7lQ4v4JSDwmV0As9GaiUsvbm0=
Expand Down Expand Up @@ -661,14 +661,14 @@ github.com/onsi/ginkgo v1.16.4/go.mod h1:dX+/inL/fNMqNlz0e9LfyB9TswhZpCVdJM/Z6Vv
github.com/onsi/ginkgo v1.16.5 h1:8xi0RTUf59SOSfEtZMvwTvXYMzG4gV23XVHOZiXNtnE=
github.com/onsi/ginkgo v1.16.5/go.mod h1:+E8gABHa3K6zRBolWtd+ROzc/U5bkGt0FwiG042wbpU=
github.com/onsi/ginkgo/v2 v2.1.3/go.mod h1:vw5CSIxN1JObi/U8gcbwft7ZxR2dgaR70JSE3/PpL4c=
github.com/onsi/ginkgo/v2 v2.13.0 h1:0jY9lJquiL8fcf3M4LAXN5aMlS/b2BV86HFFPCPMgE4=
github.com/onsi/ginkgo/v2 v2.13.0/go.mod h1:TE309ZR8s5FsKKpuB1YAQYBzCaAfUgatB/xlT/ETL/o=
github.com/onsi/ginkgo/v2 v2.13.2 h1:Bi2gGVkfn6gQcjNjZJVO8Gf0FHzMPf2phUei9tejVMs=
github.com/onsi/ginkgo/v2 v2.13.2/go.mod h1:XStQ8QcGwLyF4HdfcZB8SFOS/MWCgDuXMSBe6zrvLgM=
github.com/onsi/gomega v1.7.1/go.mod h1:XdKZgCCFLUoM/7CFJVPcG8C1xQ1AJ0vpAezJrB7JYyY=
github.com/onsi/gomega v1.10.1/go.mod h1:iN09h71vgCQne3DLsj+A5owkum+a2tYe+TOCB1ybHNo=
github.com/onsi/gomega v1.17.0/go.mod h1:HnhC7FXeEQY45zxNK3PPoIUhzk/80Xly9PcubAlGdZY=
github.com/onsi/gomega v1.19.0/go.mod h1:LY+I3pBVzYsTBU1AnDwOSxaYi9WoWiqgwooUqq9yPro=
github.com/onsi/gomega v1.28.1 h1:MijcGUbfYuznzK/5R4CPNoUP/9Xvuo20sXfEm6XxoTA=
github.com/onsi/gomega v1.28.1/go.mod h1:9sxs+SwGrKI0+PWe4Fxa9tFQQBG5xSsSbMXOI8PPpoQ=
github.com/onsi/gomega v1.29.0 h1:KIA/t2t5UBzoirT4H9tsML45GEbo3ouUnBHsCfD2tVg=
github.com/onsi/gomega v1.29.0/go.mod h1:9sxs+SwGrKI0+PWe4Fxa9tFQQBG5xSsSbMXOI8PPpoQ=
github.com/opencontainers/go-digest v1.0.0 h1:apOUWs51W5PlhuyGyz9FCeeBIOUDA/6nW8Oi/yOhh5U=
github.com/opencontainers/go-digest v1.0.0/go.mod h1:0JzlMkj0TRzQZfJkVvzbP0HBR3IKzErnv2BNG4W4MAM=
github.com/opencontainers/image-spec v1.1.0-rc4 h1:oOxKUJWnFC4YGHCCMNql1x4YaDfYBTS5Y4x/Cgeo1E0=
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 759c0b0

Please sign in to comment.