Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

815-fix: Search result links incorrect color #816

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

SpaNb4
Copy link
Collaborator

@SpaNb4 SpaNb4 commented Mar 17, 2025

What type of PR is this? (select all that apply)

  • πŸ• Feature
  • πŸ› Bug Fix
  • 🚧 Breaking Change
  • πŸ§‘β€πŸ’» Code Refactor
  • πŸ“ Documentation Update

Description

Screenshots, Recordings

before
image

after
image

Added/updated tests?

  • πŸ‘Œ Yes
  • πŸ™…β€β™‚οΈ No, because they aren't needed
  • πŸ™‹β€β™‚οΈ No, because I need help

[optional] Are there any post deployment tasks we need to perform?

[optional] What gif best describes this PR or how it makes you feel?

@github-actions github-actions bot changed the title fix: 815 - docs page styles 815-fix: Search result links incorrect color Mar 17, 2025
Copy link

Lighthouse Report:

  • Performance: 65 / 100
  • Accessibility: 96 / 100
  • Best Practices: 100 / 100
  • SEO: 100 / 100

View detailed report

@ansivgit
Copy link
Collaborator

ansivgit commented Mar 22, 2025

Some issue with search again
image
image
image

@ansivgit
Copy link
Collaborator

Also when I scroll down menu and go to some subsection, I expect that I can see highlighting this subsection title, but menu scroll up automatically and it may be unsuspected

Screen.Recording.2025-03-22.at.16.37.13.mov

@SpaNb4
Copy link
Collaborator Author

SpaNb4 commented Mar 22, 2025

Some issue with search again image image image

That's not a bug, but mocked data for local development

@SpaNb4
Copy link
Collaborator Author

SpaNb4 commented Mar 22, 2025

Also when I scroll down menu and go to some subsection, I expect that I can see highlighting this subsection title, but menu scroll up automatically and it may be unsuspected

Screen.Recording.2025-03-22.at.16.37.13.mov

Fixed that issue with re-renders

Copy link

Lighthouse Report:

  • Performance: 95 / 100
  • Accessibility: 96 / 100
  • Best Practices: 100 / 100
  • SEO: 100 / 100

View detailed report

@ansivgit
Copy link
Collaborator

There is some issue with a vertical scroll in sidebar - last menu item doesn't visible until main content doesn't scroll to the bottom

Screen.Recording.2025-03-24.at.13.51.11.mov

text-decoration: none;

&:hover {
color: $color-gray-900;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should make the highlight or increase font-weight on hover, in my opinion it's not very visible now
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Docs] Search result links have incorrect color
3 participants