DRAFT - 765-fix: Fix styles active menu item #814
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
changed the title
YulikK
approved these changes
Mar 12, 2025
Quiddlee
approved these changes
Mar 12, 2025
|
The arrow's focus state could be improved This isn't due to your changes, but the spacing is inconsistent here |
|
Lighthouse Report:
|
SpaNb4
requested changes
Mar 15, 2025
ansivgit
reviewed
Mar 17, 2025
ansivgit
reviewed
Mar 18, 2025
| setDropdownOpen((prev) => !prev); | ||
| } | ||
| }; | ||
|
|
||
| const handleEscKeyPress = (e: KeyboardEvent<HTMLElement>) => { | ||
| if (e.code === 'Escape') { |
There was a problem hiding this comment.
Let's all keys' codes move to constant like KEY_CODES = {ESCAPE: 'Escape', .....} You could add it here src/core/const/index.ts
YulikK
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (select all that apply)
Description
Fixed styles for the active menu item and resolved the Lighthouse issue related to the touch target size of the dropdown arrow.
Related Tickets & Documents
Screenshots, Recordings
Before:
After:
Added/updated tests?
[optional] Are there any post deployment tasks we need to perform?
[optional] What gif best describes this PR or how it makes you feel?