Migrate server rollbar tests to mocha #1212
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the server Rollbar tests from vows to mocha and updates related test utilities and coverage for telemetry, logging, exception handling, and configuration.
- Removed custom process.env setup in some tests
- Added new mocha-based test files covering Rollbar telemetry, logging, handler behavior, constructor configuration, and lambda scenarios
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/server.telemetry.mocha.test.js | Removed process.env assignment and converted telemetry tests to mocha syntax |
| test/server.rollbar.test-utils.js | Introduced common test utilities for use across server Rollbar tests |
| test/server.rollbar.misc.mocha.test.js | Added miscellaneous tests for Rollbar methods |
| test/server.rollbar.logging.mocha.test.js | Added logging tests with various option combinations and callbacks |
| test/server.rollbar.handlers.mocha.test.js | Added tests for exception and rejection handling with uncaught and unhandled rejections |
| test/server.rollbar.constructor.mocha.test.js | Added tests ensuring proper constructor behavior, configuration, and tracer setup |
| test/server.lambda.mocha.test.js | Migrated lambda tests to mocha removing extraneous environment variable setup |
waltjones
approved these changes
Jun 6, 2025
matux
force-pushed
the
matux/vows-to-mocha-4
branch
3 times, most recently
from
5cbb86f to
df2775f
Compare
matux
force-pushed
the
matux/vows-to-mocha-5
branch
from
291f8dd to
d9a234c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
This PR migrates the server test
rollbarto mocha from vows.The
server.rollbartest file was gigantic. I've broken it into multiple parts and added a small utility file with the shared stuff (just a couple dozen lines).Related issues
SDK-490/migrate-vowsjs-to-mocha
SDK-491/complete-server-test-es-module-migration