Fix "rokit update" always reporting tools as up-to-date#111
Merged
Conversation
filiptibell
approved these changes
May 9, 2026
Collaborator
filiptibell
left a comment
filiptibell
left a comment
There was a problem hiding this comment.
Good catch! Yeah, this must have been a copy-paste mistake or something. Nice to see it fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
rokit updatethe output would always tell you that "All tools are already up-to-date!" even if they were not and the command actually updated your rokit.toml. This was by no means a critical bug b/c it ultimately still did it's intended function it just output the wrong message to the user.As far as I can tell it was caused by recomputing
tools_changedin step 6 with the mutated (updated) manifest causingspec_oldto always equalspec_new. Fix seems simple enough, just don't recompute and use the originaltools_changedvalue that was computer before the manifest was mutated.