Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loop over all possibilities and test if one of them is disabled #462

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

typemytype
Copy link
Member

@typemytype typemytype commented Mar 5, 2025

@typesupply please test before merging...

import defcon 

f = defcon.Font()

names = ["A"]

f.dispatcher.holdNotifications()
for name in names:
    f.newGlyph(name) 

f.dispatcher.releaseHeldNotifications()

this script throws an error: defcon/objects/layer.py", line 707, in _glyphNameChange KeyError: None

--> first loop over all possible combinations and test it against the disabled notifications, if found just return, otherwise look to store them in the held notifications

@codecov-commenter
Copy link

codecov-commenter commented Mar 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.47%. Comparing base (923bd19) to head (3dbcd4c).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #462   +/-   ##
=======================================
  Coverage   87.47%   87.47%           
=======================================
  Files          57       57           
  Lines       10365    10366    +1     
  Branches     1337     1338    +1     
=======================================
+ Hits         9067     9068    +1     
  Misses        921      921           
  Partials      377      377           
Flag Coverage Δ
unittests 87.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@typesupply
Copy link
Member

This looks good to me.

@typesupply typesupply merged commit 92e5b7e into master Mar 5, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants