Skip to content

Loop over all possibilities and test if one of them is disabled - #462

Merged
typesupply merged 1 commit into
masterfrom
disabledNotificationFirst
Mar 5, 2025
Merged

typesupply merged 1 commit into
masterfrom
disabledNotificationFirst

Conversation

@typemytype

@typemytype typemytype commented Mar 5, 2025 •

Copy link
Copy Markdown
Member

@typesupply please test before merging...

import defcon 

f = defcon.Font()

names = ["A"]

f.dispatcher.holdNotifications()
for name in names:
    f.newGlyph(name) 

f.dispatcher.releaseHeldNotifications()

this script throws an error: defcon/objects/layer.py", line 707, in _glyphNameChange KeyError: None

--> first loop over all possible combinations and test it against the disabled notifications, if found just return, otherwise look to store them in the held notifications

@codecov-commenter

codecov-commenter commented Mar 5, 2025 •

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.47%. Comparing base (923bd19) to head (3dbcd4c).
⚠️ Report is 39 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #462   +/-   ##
=======================================
  Coverage   87.47%   87.47%           
=======================================
  Files          57       57           
  Lines       10365    10366    +1     
  Branches     1337     1338    +1     
=======================================
+ Hits         9067     9068    +1     
  Misses        921      921           
  Partials      377      377           
Flag Coverage Δ
unittests 87.47% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@typesupply

Copy link
Copy Markdown
Member

This looks good to me.

@typesupply
typesupply merged commit 92e5b7e into master Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants