fix(opencode): render tool calls and drop stderr migration noise#639
Merged
wesm merged 3 commits intoroborev-dev:mainfrom Apr 12, 2026
Merged
Conversation
opencode 1.4.3 emits outer event type "tool_use" with a nested part.type of "tool"; earlier versions used outer "tool". The renderer previously only matched outer "tool", so every Read, Glob, Bash call from recent opencode versions was silently dropped from the live job log. Merge the existing Gemini-only "tool_use" branch with the opencode part-based branch, routing by payload shape: a nested "part" object is opencode, a top-level tool_name is Gemini. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
roborev: Combined Review (
|
opencode prints sqlite-migration progress to stderr on every invocation (e.g. "Performing one time database migration...", "sqlite-migration:0", "Database migration complete."), which dominates the live log for short reviews and buries actual activity. Disable stderr streaming for opencode; the full stderr is still captured into the streaming result buffer and surfaced via formatDetailedCLIWaitError on non-zero exit, so real failures still reach the user. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
The prior commit disabled live stderr streaming for opencode, relying on runStreamingCLI's captured Stderr being surfaced through formatDetailedCLIWaitError when the process exits non-zero. Add a regression test that drives a non-zero exit with a real error line on stderr and asserts the line appears in the returned error message, locking in the failure-visibility guarantee. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
cpcloud
force-pushed
the
worktree-prancy-sprouting-salamander
branch
from
e0042ab to
40f0d2b
Compare
roborev: Combined Review (
|
mariusvniekerk
approved these changes
Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tool_use(opencode 1.4+); earlier versions usedtooland the renderer was silently dropping every tool call from the live job log on current opencode.tool_usebranch is shared with Gemini; routing is by payload shape (partobject → opencode, top-leveltool_name→ Gemini).sqlite-migration:*progress and thePerforming one time database migration.../Database migration complete.banners to stderr on every invocation; those lines were dominating the log for short reviews.formatDetailedCLIWaitError. A new test,TestOpenCodeReviewStderrPreservedInError, drives an exit-1 scenario and asserts the stderr content appears in the returned error.