Added the ability to pass the Protocol property to the PresignedRequest #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pchol
force-pushed
the
pass-protocol-to-presigned-request-in-aws-storage
branch
from
16171a4 to
047b160
Compare
Pchol
force-pushed
the
pass-protocol-to-presigned-request-in-aws-storage
branch
from
047b160 to
f5996f2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When working within an internal network, it's possible to access S3 using the HTTP protocol by setting ServiceUrl = http://s3_endpoint. However, in this case, the GetPresignedRequest method still returns a URL with HTTPS. To fix this, you need to pass the Protocol property with the value Http in the PresignedRequest.
This MR makes it possible.