-
Notifications
You must be signed in to change notification settings - Fork 394
feat: add option to configure available tls cipher suites for relay #1914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
✅ All contributors have signed the CLA! Thank you for signing the Contributor License Agreement. Your contribution can now be reviewed and merged! 🚀 |
|
I have read the CLA Document and I hereby sign the CLA |
|
|
@sdellaco thanks for contributing this. I will review and merge as soon as I can. At a quick glance it looks complete. |
|
/rebase |
|
@rnwood any update on this? |
|
/rebase |
c107966 to
6c1495b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds configuration options for TLS cipher suites and certificate revocation checking when relaying SMTP messages. It enables administrators to customize the security settings for relay connections by specifying allowed cipher suites and controlling certificate revocation validation.
- Added
SslCipherSuitesPolicyproperty to configure allowed TLS cipher suites for relay connections - Added
CheckCertificateRevocationproperty to control certificate revocation checking - Implemented cipher suite parsing with .NET 5.0+ conditional compilation and platform compatibility handling
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Rnwood.Smtp4dev/Startup.cs | Implements cipher suite policy configuration with enum parsing and platform exception handling for the SMTP relay client factory |
| Rnwood.Smtp4dev/Server/Settings/RelayOptionsSource.cs | Adds SslCipherSuitesPolicy and CheckCertificateRevocation properties with default values to the relay configuration source |
| Rnwood.Smtp4dev/Server/Settings/RelayOptions.cs | Adds SslCipherSuitesPolicy and CheckCertificateRevocation properties with default values to the relay options record |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <[email protected]>
|


Closes #1913