Skip to content

Conversation

@sdellaco
Copy link
Contributor

Closes #1913

@github-actions
Copy link
Contributor

github-actions bot commented Oct 13, 2025

All contributors have signed the CLA!

Thank you for signing the Contributor License Agreement. Your contribution can now be reviewed and merged! 🚀
Posted by the CLA Assistant Lite bot.

@sdellaco
Copy link
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
27.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@rnwood
Copy link
Owner

rnwood commented Oct 18, 2025

@sdellaco thanks for contributing this. I will review and merge as soon as I can. At a quick glance it looks complete.

@rnwood
Copy link
Owner

rnwood commented Oct 18, 2025

/rebase

@sdellaco
Copy link
Contributor Author

@rnwood any update on this?

@rnwood
Copy link
Owner

rnwood commented Dec 4, 2025

/rebase

Copilot finished reviewing on behalf of rnwood December 4, 2025 18:06
@rnwood rnwood self-requested a review December 4, 2025 18:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds configuration options for TLS cipher suites and certificate revocation checking when relaying SMTP messages. It enables administrators to customize the security settings for relay connections by specifying allowed cipher suites and controlling certificate revocation validation.

  • Added SslCipherSuitesPolicy property to configure allowed TLS cipher suites for relay connections
  • Added CheckCertificateRevocation property to control certificate revocation checking
  • Implemented cipher suite parsing with .NET 5.0+ conditional compilation and platform compatibility handling

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
Rnwood.Smtp4dev/Startup.cs Implements cipher suite policy configuration with enum parsing and platform exception handling for the SMTP relay client factory
Rnwood.Smtp4dev/Server/Settings/RelayOptionsSource.cs Adds SslCipherSuitesPolicy and CheckCertificateRevocation properties with default values to the relay configuration source
Rnwood.Smtp4dev/Server/Settings/RelayOptions.cs Adds SslCipherSuitesPolicy and CheckCertificateRevocation properties with default values to the relay options record

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@rnwood rnwood merged commit 9252999 into rnwood:master Dec 4, 2025
3 of 16 checks passed
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
27.6% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[feature] Add option for selecting TLS cipher-suites on supported platforms (Linux with OpenSSL)

2 participants