New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve built-in Rails support for Dataloader #5213

Merged

rmosolgo merged 13 commits into master from rails-dataloader

Feb 14, 2025

Owner

rmosolgo commented Jan 24, 2025 •

edited

Loading

I was helping someone move database access to Dataloader and decided that some of the "boilerplate" could be shipped with the gem:

Record and Association source classes
- Check for already-loaded associations before pausing the Fiber
~~ActiveStorage sources, others?~~ not now
Helper methods for built-in sources
Field config helpers to automatically call dataload helpers (eg dataload_association: true)
Would enabling ActiveRecord Strict mode help catch these missing batch loads?
- Tried this in https://github.com/rmosolgo/graphql-ruby/compare/try-strict-loading?expand=1
~~Add trace hooks for dataloader sources~~ done in Add PerfettoTracing for detailed query execution profiling #5214

rmosolgo added 7 commits

January 18, 2025 10:33


          Add ActiveRecordSource

569f58e


          Add ActiveRecordAssociationSource

d036245


          Add HasDataloader

e2c45a0


          Merge branch 'master' into rails-dataloader

a43bf11


          Merge branch 'master' into rails-dataloader

0aa0153


          Fix merge

746b0df


          Fix loading by casted key

6e8bea2

github-actions bot reviewed

View reviewed changes

lib/graphql/dataloader/active_record_association_source.rb Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

lib/graphql/dataloader/active_record_association_source.rb Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

lib/graphql/dataloader/active_record_association_source.rb Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

lib/graphql/schema/member/has_dataloader.rb Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

lib/graphql/schema/member/has_dataloader.rb Show resolved Hide resolved

rmosolgo added 3 commits

February 14, 2025 07:07


          Fix attribute access for Rails 7

2d70803


          Fix lint error


          Bypass sync when association is already loaded

d787b48

github-actions bot reviewed

View reviewed changes

lib/graphql/dataloader/active_record_association_source.rb Outdated Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

lib/graphql/dataloader/active_record_association_source.rb Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

lib/graphql/dataloader/active_record_association_source.rb Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

lib/graphql/dataloader/active_record_association_source.rb Show resolved Hide resolved

rmosolgo added 2 commits

February 14, 2025 09:55


          Add test coverage for dataloader helpers

a26bf7b


          Merge branch 'master' into rails-dataloader

217ae2b

github-actions bot reviewed

View reviewed changes

lib/graphql/schema/member/has_dataloader.rb Show resolved Hide resolved

github-actions bot reviewed

View reviewed changes

lib/graphql/schema/member/has_dataloader.rb Show resolved Hide resolved


          improve test coverage

rmosolgo added this to the 2.4.10 milestone

rmosolgo merged commit a5451ab into master

14 of 15 checks passed

rmosolgo deleted the rails-dataloader branch

February 14, 2025 20:56

dbackeus commented Feb 25, 2025

Is "how to use" documented somewhere?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet