Look for libraries in /usr/lib too #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andreabolognani
added a commit
to andreabolognani/kubevirt
that referenced
this pull request
Sep 2, 2022
The version of bazeldnf we currently use doesn't handle gracefully the fact that, in CentOS Stream 9, ld-linux-aarch64.so lives under /usr/lib instead of /usr/lib64. The latter is still used for ld-linux-x86_64.so even in CentOS Stream 9, and was used for both in CentOS Stream 8, hence why we hadn't encountered this limitation until now. I'm pointing to a branch in my personal fork of bazeldnf that contains the necessary fixes to demonstrate things, but we'll have to wait until rmohr/bazeldnf#22 is merged and a new bazeldnf release is tagged before we can merge these changes. Signed-off-by: Andrea Bolognani <[email protected]>
|
KubeVirt PR that depends on these changes, as well as #20 and #21: kubevirt/kubevirt#8404 |
Not all libraries are necessarily found in /usr/lib64, even on 64-bit systems. Make it possible to pass a list of directories and only error out if a given library can't be found in any of those. Signed-off-by: Andrea Bolognani <[email protected]>
On current aarch64 Linux versions such as CentOS Stream 9 and Fedora 36, ld-linux-aarch64.so is found in /usr/lib instead of /usr/lib64. Signed-off-by: Andrea Bolognani <[email protected]>
rmohr
reviewed
Sep 5, 2022
|
thanks a lot |
|
Thank you! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On current aarch64 Linux versions such as CentOS Stream 9 and Fedora 36,
ld-linux-aarch64.sois found in/usr/libinstead of/usr/lib64.