-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set TotalEnvSteps as the default Tensorboard x-axis #1069
Conversation
We need to merge the dowel changes first, release a dowel version, then bump the version in garage. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Additionally, I like this feature, it is useful for comparing against other paper results that log in this fashion
Codecov Report
@@ Coverage Diff @@
## master #1069 +/- ##
==========================================
+ Coverage 82% 86.15% +4.14%
==========================================
Files 161 161
Lines 7809 7807 -2
Branches 992 992
==========================================
+ Hits 6404 6726 +322
+ Misses 1208 890 -318
+ Partials 197 191 -6
Continue to review full report at Codecov.
|
This PR will be ready when dowel 0.0.3 is tagged. |
87cb32a
to
e717b5d
Compare
e717b5d
to
5efc084
Compare
Let me know when this is ready and I will force-push it. |
@ryanjulian If we don't care about the codedev, then this should be ready. |
This PR sets
TotalEnvSteps
as the default tensorboard scalar log x-axis. This PR depends on rlworkgroup/dowel#38.