Add be.AssignedAs and deprecate be.Panic #5
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think the current panic assertion is very good, because asserting _that_ something panics is a lot less effective than asserting the _value_ of a panic. So this refactor makes it so you have to orchestrate the panic recovery yourself, but also makes it easier to assert something of type `any` with a more specific assertion. And generally I think `be.AssignedAs` is a smart assertion to have. It roughly resembles the shape of `be.ErrorAs`, so it shouldn't be very surprising.
rliebz
force-pushed
the
panic-assertions
branch
from
f7a8b38 to
d90ad51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't think the current panic assertion is very good, because asserting that something panics is a lot less effective than asserting the value of a panic. So this refactor makes it so you have to orchestrate the panic recovery yourself, but also makes it easier to assert something of type
anywith a more specific assertion.And generally I think
be.AssignedAsis a smart assertion to have. It roughly resembles the shape ofbe.ErrorAs, so it shouldn't be very surprising.