Tweak a few test case names to use TestCaseCamelCaseConvention
#395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bgentry
approved these changes
Aug 14, 2025
Contributor
|
Oh this may also conflict slightly with #379, please hold off if that's ok since it's not urgent at all. |
Collaborator
Author
|
Roger. |
Contributor
|
@brandur ping on getting this minor cleanup shipped when you can 🙏 |
brandur
force-pushed
the
brandur-test-case-names
branch
from
7eba2b8 to
c90e45d
Compare
Collaborator
Author
|
Rebased and the changes were no longer needed it seems. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a couple tweaks to test names to use
CamelCaseConventioninsteadof "words with spaces convention". The former is used universally in
other River projects and is kind of nice because (1) a name can be
yanked by double clicking it or a two-letter Vim motion like
yw, and(2) the test names are the same in the editor as they are when Go is
running. Using spaces, Go mutates test names to include underscores like
words_with_spaces_convention.